Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8895] Add search profile alerts to plan list page #6060

Merged

Conversation

sevfurneaux
Copy link
Collaborator

Describe your changes
This PR adds search profile alerts to plan list page.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@sevfurneaux sevfurneaux self-assigned this Feb 11, 2025
@sevfurneaux sevfurneaux force-pushed the sf-2025-02-add-search-profile-alerts-in-project-overview branch from 90a06d6 to 0021a76 Compare February 11, 2025 09:48
title: translated.searchProfileLimitExceededTitle,
message: (
<div
dangerouslySetInnerHTML={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vellip @sevfurneaux i remember there were some reservations about this on a different PR, but I can't remember exactly. Maybe @vellip want to have a second 👀 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hom3mad3 I spoke to @vellip about this this morning, all good!

@hom3mad3
Copy link
Contributor

@sevfurneaux thanks! just a small question. otherwise, feel free to merge ✨

@sevfurneaux sevfurneaux merged commit 3c34d8a into dev Feb 11, 2025
2 checks passed
@sevfurneaux sevfurneaux deleted the sf-2025-02-add-search-profile-alerts-in-project-overview branch February 11, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants